Update vscode-textmate dependency
#12963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
monaco
|
@msujew this PR will resolve the Chrome 117 twigg color coding issue? |
|
@rahulgupta-acquia Yes, it explicitly says so in the testing instructions. Note that this change will only get released in a month. You can set a resolution for vscode textmate to 9.0.0 in your project, and that should work as well. |
|
Thanks @msujew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #12960.
Updates our
vscode-textmatedependency to fix an issue in plist xml parsing that only seems to appear in newer versions of Chrome.How to test
.twigfile, the highlighting should work as expected:{% for user in users %} * {{ user.name }} {% else %} No users have been found. {% endfor %}Review checklist
Reminder for reviewers